Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libshout-idjc Warning fix #4739

Merged
merged 4 commits into from
May 5, 2022
Merged

libshout-idjc Warning fix #4739

merged 4 commits into from
May 5, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented May 3, 2022

I have noticed that we have enabled -Wall for windows which is literal all.
Now there are some real issue warned, but I consider fixing them to risky in a stable build and also considering that we update libshout-idjc one day. See #4723

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 1ce7b20 into mixxxdj:2.3 May 5, 2022
@uklotzde
Copy link
Contributor

uklotzde commented May 6, 2022

cc1: warning: command-line option ‘-Woverloaded-virtual’ is valid for C++/ObjC++ but not for C
[28/795] Building C object lib/libshout-idjc/CMakeFiles/shout_mixxx.dir/src/shout.c.o
cc1: warning: command-line option ‘-Woverloaded-virtual’ is valid for C++/ObjC++ but not for C
/home/uk/volumes/Build/cpp/mixxx/lib/libshout-idjc/src/shout.c: In function ‘try_connect’:
/home/uk/volumes/Build/cpp/mixxx/lib/libshout-idjc/src/shout.c:1310:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1310 |             self->state = SHOUT_STATE_REQ_CREATION;
      |             ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/uk/volumes/Build/cpp/mixxx/lib/libshout-idjc/src/shout.c:1312:9: note: here
 1312 |         case SHOUT_STATE_REQ_CREATION:
      |         ^~~~

@daschuer daschuer deleted the warning_fix_win branch November 16, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants