Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): include cpp guideline support library #4776

Closed
wants to merge 1 commit into from
Closed

feat(build): include cpp guideline support library #4776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,6 +1881,18 @@ if(GNU_GCC OR LLVM_CLANG)
endif()
target_link_libraries(mixxx-lib PRIVATE FpClassify)

# Cpp Core Guideline Support Library (GSL)
include(FetchContent)

FetchContent_Declare(GSL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work without internet access during the build? If yes then in which directory are those downloaded archives expected to reside in?

Please compare with how libkeyfinder is integrated. This allows to manually download the archives in advance and run the build without an internet connection.

Otherwise it would break at least the RPM Fusion builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhmmm yeah, this was the recommend integration by MS, I'll look into offline ways to build this.

GIT_REPOSITORY "https://github.com/microsoft/GSL"
GIT_TAG "v4.0.0"
)

FetchContent_MakeAvailable(GSL)

target_link_libraries(mixxx-lib PRIVATE GSL)

# googletest
# Required to use the macro FRIEND_TEST from <gtest/gtest_prod.h>
# in production code
Expand Down