Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): Update Arch Linux docker image to Qt 6.3.0 and add ms-gsl #4795

Merged
merged 1 commit into from
Jun 12, 2022
Merged

ci(github): Update Arch Linux docker image to Qt 6.3.0 and add ms-gsl #4795

merged 1 commit into from
Jun 12, 2022

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus requested a review from Swiftb0y June 11, 2022 22:58
Swiftb0y
Swiftb0y approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@Swiftb0y Swiftb0y merged commit 1f22056 into mixxxdj:main Jun 12, 2022
@Swiftb0y
Copy link
Member

ping @Holzhaus
This is broken after merging to main. Has the base arch container changed to not include ssh-agent anymore?
https://github.com/mixxxdj/mixxx/runs/6849295441

@Holzhaus Holzhaus mentioned this pull request Jun 12, 2022
Merged
@Holzhaus
Copy link
Member Author

This is broken after merging to main. Has the base arch container changed to not include ssh-agent anymore?

Maybe. I added openssh to the dockerfile explicitly: Holzhaus/mixxx-ci-docker@8eed29a

PR: #4798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @Swiftb0y