WFindOnWebMenu: Implementing the factory pattern #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is the original PR of find on web feature (and also continued of the #4772). What do you think? Any ideas and feedbacks? Should It be merged in two steps or in one step? |
|
@fatihemreyildiz The previous PR is now merged, can you rebase this on main and force push, that we see a clean diff? |
fatihemreyildiz
force-pushed
the
findonweb
branch
from
1ac29bf
to
b53dcf6
Compare
|
Done 👍 |
daschuer
approved these changes
Jul 8, 2022
|
@Swiftb0y Can you have a final look? |
Swiftb0y
requested changes
Jul 9, 2022
Swiftb0y
approved these changes
Jul 11, 2022
wfindonwebmenu: includes changes. wfindonwebmenu: service url composer added. findonwebmenufactory: class moved in namespace. wfindonwebmenu: addActionServiceMenu add, for DRY wfindonwebmenu: url composer added to each service
fatihemreyildiz
force-pushed
the
findonweb
branch
from
9e22165
to
a932ff5
Compare
|
Two approvals and squashed = ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone, this PR is the continue of #4772
This feature is called Find On Web. Which is located under the Metadata menu, with a sub menus of different online databases that can help users to look up track properties on online databases. It will populate the fav browser of the user with the given service and query. It basically looks like this:
This feature is aimed for the users who accordingly looks additional info about the tracks. There are few queries with the chosen track. We can lookup for only for the artist, only for the track title (It is good for to look for remixes), track title + artist (make sure we find the correct song), artist + album (To find the other songs in that album). If has no property, the menu is grayed out.
This can be also helpful for later for to find suggested songs on the online services as discussed on the Zulip channel.
Factory Method used for this feature, so for later on another online databases (services) can be added easily by just changing the URL of the searches.