-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoDJ: Show total track time #4846
base: 2.4
Are you sure you want to change the base?
Changes from all commits
f0b4f6d
a29f375
7f94c69
f059b36
865a429
4a110a9
4555fe8
8850afb
7cc0230
1798e32
9fadb20
fe7b602
5f588b0
6861456
86c9577
ef6a67c
ea0e42d
18dd4cb
85aedee
310c57d
bae8706
767e6d6
9f901aa
4c0ccae
e6a954a
dea1a7c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#pragma once | ||
|
||
#include "library/trackset/playlist/playlistid.h" | ||
#include "util/db/dbnamedentity.h" | ||
|
||
class Playlist : public DbNamedEntity<PlaylistId> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this new class used? Can this be just a typedef? The name is IMHO ambiguous. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, Well, I was trying to follow and replicate how |
||
public: | ||
explicit Playlist(PlaylistId id = PlaylistId()) | ||
: DbNamedEntity(id) { | ||
} | ||
~Playlist() override = default; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#pragma once | ||
|
||
#include "util/db/dbid.h" | ||
|
||
class PlaylistId : public DbId { | ||
public: | ||
// Inherit constructors from base class | ||
using DbId::DbId; | ||
}; | ||
|
||
Q_DECLARE_TYPEINFO(PlaylistId, Q_MOVABLE_TYPE); | ||
Q_DECLARE_METATYPE(PlaylistId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other features have the text left aligned. I think we should do it here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well,
labelSelectionInfo
does not have text alignment set, so I'm slightly confused whylabelTotalInfo
would be different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because in the analysis view the spacer is on the very right.
I have no strong preferences for one of the options but they should be the same.