Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire Ubunu Impish, because near to EOL and a pendig GCC 11 bug #4849

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Retire Ubunu Impish, because near to EOL and a pendig GCC 11 bug #4849

merged 1 commit into from
Jul 10, 2022

Conversation

daschuer
Copy link
Member

@github-actions github-actions bot added the build label Jul 10, 2022
Swiftb0y
Swiftb0y approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly misleading title as the issue actually seems to be a GCC 11 bug which is not present on gcc 10. But yes, since impish is EOL anyways, simply dropping it should be ok IMO.

@daschuer daschuer changed the title Retire Ubunu Impish, because issues with C++20 support Retire Ubunu Impish, because near to EOL and a pendig GCC 11 bug Jul 10, 2022
@daschuer
Copy link
Member Author

I have improve the title. Merge?
I have restored a C++17 version for Impish here:
https://launchpad.net/~mixxx/+archive/ubuntu/nightlies
If we merge this before anything else this version will stick as our final Impish version.

@Swiftb0y
Copy link
Member

Sure.

@Swiftb0y Swiftb0y merged commit 387f14d into mixxxdj:main Jul 10, 2022
@daschuer daschuer deleted the impish_retire branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @Swiftb0y