Shout.c : Add a missing c++14 fall through comment #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Jul 19, 2022
| @@ -1308,6 +1308,7 @@ static int try_connect(shout_t *self) | |||
| } | |||
| #endif | |||
| self->state = SHOUT_STATE_REQ_CREATION; | |||
| /* fall through */ | |||
There was a problem hiding this comment.
Why don't we use the c++17 attribute? https://en.cppreference.com/w/cpp/language/attributes/fallthrough
Suggested change
| /* fall through */ | |
| [[falltrough]]; |
There was a problem hiding this comment.
I did this for the lowest impact.
I am afraid switching to c++17 may break something else.
All other places in the source use this comment and it is not our code.
|
There are still a bunch of other warnings related to libshout. I assume you don't intend to fix them? |
|
I can have a look if there are low hanging fruits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source is compiled wit the default c++14 and uses /* fall through */ to silence the -Wimplicit-fallthrough=3 enabled by -Wextra.