Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): replace deprecated macos-10.15 with macos-11 #4863

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix(ci): replace deprecated macos-10.15 with macos-11 #4863

merged 2 commits into from
Jul 26, 2022

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y
Copy link
Member Author

lets just see if ci still builds. I'm not familiar enough with macos to know if this has any consequences. We don't really have a choice anyways.

@Swiftb0y Swiftb0y changed the base branch from main to 2.3 July 21, 2022 15:18
@daschuer
Copy link
Member

It looks like we hit this cpack bug:
https://gitlab.kitware.com/cmake/cmake/-/issues/20889
Hopefully updating to CMake 3.19 will solve the issue.

mixxx/.github/workflows/build.yml

Line 156 in 112bbb4

cmake-version: '3.16.x'

CMake 3.23 is installed by default:
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md

We install the minimum version to check our min requirement.

@github-actions github-actions bot added the build label Jul 21, 2022
@Swiftb0y
Copy link
Member Author

Yes I just figured that out too. I set it to 3.19

@Swiftb0y
Copy link
Member Author

macOS CI is green. How can we make sure this does not cause the dreaded performance regressions. Should we just ping our macos-testers team on Zulip?
Also pinging @Be-ing because he's more familiar with macos than me.

@daschuer
Copy link
Member

@fwcd can you verify the build?

daschuer
daschuer requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have not the chance to not merge this.
Even if we have performance issues we need to solve them on the new build machine.

CMakeLists.txt Outdated Show resolved Hide resolved
@fwcd
Copy link
Member

fwcd commented Jul 22, 2022

The macOS build seems to run fine (in my very limited testing).

@daschuer
Copy link
Member

Thank you.

@daschuer daschuer merged commit 4931f4f into mixxxdj:2.3 Jul 26, 2022
@Swiftb0y Swiftb0y deleted the upgrade-ci-macos11 branch July 26, 2022 15:37
@fwcd fwcd mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftb0y @daschuer @fwcd