Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show time in the timestamp column #4900

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Show time in the timestamp column #4900

merged 5 commits into from
Oct 28, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer added this to the 2.4.0 milestone Aug 19, 2022
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
@daschuer
Copy link
Member Author

Done.

@ronso0 ronso0 linked an issue Aug 25, 2022 that may be closed by this pull request
Timestamp and Last Played column has only date #10726
Closed
@ronso0
Copy link
Member

ronso0 commented Aug 25, 2022 •
edited
Loading

Changing the 'Timestamp' sort order in History doesn't work unfortunately, sort order is stuck when clicking that header.

@daschuer
Copy link
Member Author

daschuer commented Sep 9, 2022

Done, now sorting works as well.

ronso0
ronso0 approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as desired, just a question.

src/library/rekordbox/rekordboxfeature.cpp Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Oct 28, 2022

Thank you!

@ronso0 ronso0 merged commit 506ccae into mixxxdj:main Oct 28, 2022
@daschuer daschuer mentioned this pull request Oct 28, 2022
Merged
@daschuer
Copy link
Member Author

@ronso0 sorry, I messed up a merge. Fixed here: #11020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@ronso0 ronso0 ronso0 approved these changes

Assignees
No one assigned
Labels
code quality library needs review regression
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Timestamp and Last Played column has only date
3 participants
@daschuer @ronso0 @uklotzde