MC7000: Fix off-by-one indexing in the controller script #4902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost the entire script indexes arrays with
deckNumber
(which ranges from 1 to 4) rather thandeckOffset
(which ranges from 0 to 3). This works since JavaScript implicitly lets the user assign to out-of-bounds indices:Since most of the script doesn't care about the initial values, this bug doesn't affect the actual functionality much, since JS is happy to use indices 1-4 instead and ignore the value at index 0.
This behavior is subtle and unintuitive, especially with regards to the default values, therefore this PR fixes the script to use the correct indexing (from 0 to 3).