Dispose Track::refreshCoverImageDigest() reading covers from the main thread #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread. This fixes https://bugs.launchpad.net/mixxx/+bug/1905124 After a cover is read by the CoverArtDelegate via a worker thread, it tries to update the Cover Image Digest via a Track object. During creation of this Track object, the cover is read again this time from the main thread, creating the scrolling issue.
uklotzde
reviewed
Aug 20, 2022
uklotzde
approved these changes
Aug 21, 2022
|
Thank you for checking this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugs.launchpad.net/mixxx/+bug/1905124
After a cover is read by the CoverArtDelegate via a worker thread, it tries to update the Cover Image Digest via a Track object. During creation of this Track object, the cover is read again this time from the main thread, creating the scrolling issue.
When the cover is read by widgets via an existing Track object, the CoverArtCache will update the Track object in the worker thread. There is also no need for a cover lookup in the main thread when creating the Track.