CoverArtUtils: Fix Reload From File/Folder, Updates Wrong Cover Art #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatihemreyildiz
changed the title
|
Thank you. This looks like a bug fix for 2.3. |
|
Yes, that is happening in 2.3 👍 |
daschuer
requested changes
Aug 22, 2022
fatihemreyildiz
force-pushed
the
coverartupdate
branch
from
b982dbd
to
0babd0e
Compare
fatihemreyildiz
force-pushed
the
coverartupdate
branch
from
0babd0e
to
e7bfa37
Compare
|
Does anyone else want to have a look? |
|
Thank you! |
|
Ups, this is now broken in the 2.3 branch: https://github.com/mixxxdj/mixxx/runs/7979410003 |
|
Thank you for taking care. I guess the file I just didn't get it why it failed. I hope I didn't do something missing-wrong. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve this bug mentioned on Launchpad.
This simply fixes to wrong cover art update if the names has more than one "." dot. I
track.1.mp3
track.2.mp3
track.3.mp3
track.4.jpg
track.5.jpg
If track.1-track.2-track.3's cover arts updated via "Reload from file/folder" it updates it with track.4.jpg.
With this change, it looks for the complete full name, so track.1.mp3 won't be updated with track.4.jpg.
But with that change, this can change the old behavior, if the files named as;
track.1.mp3.jpg
track.1.mp3
updating wouldn't not update the cover art, to not change the behavior of old updating, there is an another block added. If complete full name is not working, this will look for file name of the track
"track.1.mp3"and complete name of the cover art"track.1.mp3".jpg