Sound Preferences: Move Query button above the fold. #499

ywwg · 2015-02-23T16:17:26Z

Even on my high-rez screen, the Query button is way at the bottom below the input/output selectors,
and there's so much white space it's hard to even notice that there's a scroll bar on the side. This
patch puts the query button and the hint above the giant selector list.

Even on my high-rez screen, the Query button is way at the bottom below the input/output selectors, and there's so much white space it's hard to even notice that there's a scroll bar on the side. This patch puts the query button and the hint above the giant selector list.

daschuer · 2015-02-24T09:16:16Z

Thank you adopting this. It is actually also useful on tiny sceens, where Query button is hidden by default.
I have just a look at it and the query buttons appears closer to the unrelated hints than to the device tabs.
Can you arrange the Query button with the Input/output section somehow?

I also got already the experience that the tab layout just hides some infos instead of being helpful.
We have a static bottom section for a while and the region above has grown, so the original reason for the tabs seams to be gone. It just double hides infos on tiny screens (scrollbar and tab).
Would you mind to remove the tabs as well?

ywwg · 2015-03-12T02:41:07Z

I don't want to get rid of the tabs right now -- I made more tweaks, and shoved the debugging information below the fold since it's not as relevant. Still don't love it

esbrandt · 2015-03-12T15:24:39Z

Moving the button is a good idea, I`d give it a go.

Move the Query Device button into the default tab of the I/O assignment box. Stick it to the top to simulate workflow Query devices-->Select devices. Add horizontal line to give it some room.
Move debug info below the I/O box into the hint group. Provides relevant info right where is explained what to make out of it (btw. what known latency again stands for?)

daschuer · 2015-03-12T15:48:25Z

"known latency" is the value that is reported by the system when setting the buffer size.
It may be true or not, depending on the chosen sound API.

ferranpujolcamins · 2015-03-12T16:34:28Z

"Known" is confusing, it seems it is a true value. Maybe it could be
changed to "reported" or "system reported"?
El dia 12/03/2015 16.48, "Daniel Schürmann" notifications@github.com va
escriure:

"known latency" is the value that is reported by the system when setting
the buffer size.
It may be true or not, depending on the chosen sound API.

—
Reply to this email directly or view it on GitHub
#499 (comment).

ywwg · 2015-03-12T17:24:08Z

default tab

that means the query button will disappear when the users selects the other tab, so I don't want to do that. Also it'll be tricky to code and I don't want to do that either :). I'll tweak the report values into the Hints box

I don't want to do too much more tweaking to this -- I mostly just want to get the Query button into a more visible spot.

Fix OpenGL capitalization mistake

ywwg · 2015-03-12T17:44:28Z

ok I think this version is acceptable, we can continue to improve it but for now I think this is a lot better.

Conflicts: src/dlgprefsounddlg.ui

ywwg · 2015-03-17T20:58:48Z

fixed conflicts

esbrandt · 2015-03-18T12:58:18Z

Tinkered a bit with the last version of your patch.
This basically removes all unwanted vertical whitespace (around 100+ px) , and makes vertical tracking on resize behave like in all other preferences panes (resize to whitespace on bottom).

This is the last from me for this PR, use it if you like and merge already ;)

Removed a stray vertical spacer
Moved vertical spacer to the button
Changed tabs to take only minimum vertical space . Note: The cosmetic 1px spacer in the tabs are necessary, or the drop-down list fall out of ordering (e.g. Master becomes last instead 1st)
Add horizontal line to split-up from region above

diff --git a/src/dlgprefsounddlg.ui b/src/dlgprefsounddlg.ui
index a51788c..13a66a5 100644
--- a/src/dlgprefsounddlg.ui
+++ b/src/dlgprefsounddlg.ui
@@ -65,12 +65,12 @@
         <enum>Qt::Vertical</enum>
        </property>
        <property name="sizeType">
-        <enum>QSizePolicy::Preferred</enum>
+        <enum>QSizePolicy::MinimumExpanding</enum>
        </property>
        <property name="sizeHint" stdset="0">
         <size>
          <width>20</width>
-         <height>40</height>
+         <height>1</height>
         </size>
        </property>
       </spacer>
@@ -167,6 +167,13 @@
     </layout>
    </item>
    <item>
+    <widget class="Line" name="line_2">
+     <property name="orientation">
+      <enum>Qt::Horizontal</enum>
+     </property>
+    </widget>
+   </item>
+   <item>
     <layout class="QHBoxLayout" name="buttonsHLayout">
      <item>
       <widget class="QPushButton" name="queryButton">
@@ -192,6 +199,12 @@
    </item>
    <item>
     <widget class="QTabWidget" name="ioTabs">
+     <property name="sizePolicy">
+      <sizepolicy hsizetype="MinimumExpanding" vsizetype="Expanding">
+       <horstretch>0</horstretch>
+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
      <property name="currentIndex">
       <number>0</number>
      </property>
@@ -205,10 +218,13 @@
          <property name="orientation">
           <enum>Qt::Vertical</enum>
          </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::MinimumExpanding</enum>
+         </property>
          <property name="sizeHint" stdset="0">
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>1</height>
           </size>
          </property>
         </spacer>
@@ -225,10 +241,13 @@
          <property name="orientation">
           <enum>Qt::Vertical</enum>
          </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::MinimumExpanding</enum>
+         </property>
          <property name="sizeHint" stdset="0">
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>1</height>
           </size>
          </property>
         </spacer>
@@ -238,38 +257,6 @@
     </widget>
    </item>
    <item>
-    <spacer name="verticalSpacer1">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeType">
-      <enum>QSizePolicy::Expanding</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>40</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
-   <item>
-    <spacer name="verticalSpacer">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeType">
-      <enum>QSizePolicy::Expanding</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>40</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
-   <item>
     <widget class="QGroupBox" name="Hints">
      <property name="title">
       <string>Hints and Diagnostics</string>
@@ -352,6 +339,22 @@
      </layout>
     </widget>
    </item>
+   <item>
+    <spacer name="verticalSpacer">
+     <property name="orientation">
+      <enum>Qt::Vertical</enum>
+     </property>
+     <property name="sizeType">
+      <enum>QSizePolicy::Expanding</enum>
+     </property>
+     <property name="sizeHint" stdset="0">
+      <size>
+       <width>20</width>
+       <height>40</height>
+      </size>
+     </property>
+    </spacer>
+   </item>
   </layout>
  </widget>
  <layoutdefault spacing="6" margin="11"/>

ywwg · 2015-03-18T13:22:26Z

can you create a PR for my PR? I am too lazy to apply a diff manually :)

* Removed a stray vertical spacer * Moved vertical spacer to the button * Changed tabs to take only minimum vertical space. Note: The cosmetic 1px spacer in the tabs are necessary, or the drop-down list fall out of ordering (e.g. Master becomes last instead 1st) * Add horizontal line to split-up from region above

Additions to mixxxdj#499

ywwg · 2015-03-20T13:55:10Z

looks good!

Sound Preferences: Move Query button above the fold.

ywwg added 2 commits February 23, 2015 10:58

add a spacer

4ed4dad

adjustments to sound hardware prefs

fc385c8

Move diagnostic info into the box with the hints.

9b8f849

Fix OpenGL capitalization mistake

Merge branch 'master' into sound-dialog-reorder

8da2d78

Conflicts: src/dlgprefsounddlg.ui

esbrandt and others added 2 commits March 20, 2015 06:57

Merge pull request #5 from esbrandt/sound-dialog-reorder

32ca66f

Additions to mixxxdj#499

ywwg added a commit that referenced this pull request Mar 20, 2015

Merge pull request #499 from ywwg/sound-dialog-reorder

09b0223

Sound Preferences: Move Query button above the fold.

ywwg merged commit 09b0223 into mixxxdj:master Mar 20, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sound Preferences: Move Query button above the fold. #499

Sound Preferences: Move Query button above the fold. #499

ywwg commented Feb 23, 2015

daschuer commented Feb 24, 2015

ywwg commented Mar 12, 2015

esbrandt commented Mar 12, 2015

daschuer commented Mar 12, 2015

ferranpujolcamins commented Mar 12, 2015

ywwg commented Mar 12, 2015

ywwg commented Mar 12, 2015

ywwg commented Mar 17, 2015

esbrandt commented Mar 18, 2015

ywwg commented Mar 18, 2015

ywwg commented Mar 20, 2015

Sound Preferences: Move Query button above the fold. #499

Sound Preferences: Move Query button above the fold. #499

Conversation

ywwg commented Feb 23, 2015

daschuer commented Feb 24, 2015

ywwg commented Mar 12, 2015

esbrandt commented Mar 12, 2015

daschuer commented Mar 12, 2015

ferranpujolcamins commented Mar 12, 2015

ywwg commented Mar 12, 2015

ywwg commented Mar 12, 2015

ywwg commented Mar 17, 2015

esbrandt commented Mar 18, 2015

ywwg commented Mar 18, 2015

ywwg commented Mar 20, 2015