Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symbolic links when browsing tracks #581

Merged
merged 1 commit into from
May 11, 2015
Merged

Preserve symbolic links when browsing tracks #581

merged 1 commit into from
May 11, 2015

Conversation

uklotzde
Copy link
Contributor

@illuusio
Copy link
Contributor

So does this only happen when you import them again? Because in my setup those filepaths are correct.

@daschuer daschuer merged commit c332fda into mixxxdj:1.12 May 11, 2015
@uklotzde
Copy link
Contributor Author

It happens when you import a track that is already in your library (and contains a symlink in its path) again by selecting and opening it through the browse view. Even of you open those files with the same symlink path duplicate entries with the canonical path are created in the library.

Example: Use a symlink for your collection folder.

@daschuer
Copy link
Member

Oh sorry, I messed around with git and this got accidentally merged, without using GitHub.

However I have tested It and it works for me. It is a good band aid for the common case you have a symlink to your external hard drive in your Music folder.
If you pick such a track by browse, you have now duplicate.

The other direction of this bug is still open. If you brows to your external harddrive, Mixxx will add a duplicate because it is not aware that the track is already in the library via the symlink url.

This LGTM.

Thank you Uwe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants