Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More math refactor #8818

Merged
merged 3 commits into from
Aug 23, 2022
Merged

More math refactor #8818

merged 3 commits into from
Aug 23, 2022

Conversation

Swiftb0y
Copy link
Member

clang-format is weird on this unfortunately. So excuse the f'd-up formatting.

daschuer
daschuer approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer
Copy link
Member

Can you rebase out the failing commit before merge?

@Holzhaus Holzhaus marked this pull request as draft August 23, 2022 18:06
@Holzhaus
Copy link
Member

Holzhaus commented Aug 23, 2022 •
edited
Loading

Converted to draft to prevent accidental merge of thefixup! commit. Please squash.

@Swiftb0y
Copy link
Member Author

Ready. Manually verified each commit builds.

@Swiftb0y Swiftb0y marked this pull request as ready for review August 23, 2022 19:46
@daschuer
Copy link
Member

Thank you

@daschuer daschuer merged commit 4810a5c into mixxxdj:main Aug 23, 2022
@Swiftb0y Swiftb0y deleted the more-math-refactor branch August 23, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftb0y @daschuer @Holzhaus