-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[portaudio] Update overlay to version v19.7.0+2023-04-04 #63
Conversation
enable_jack_on_windows.patch to eneble JACK on windows pa_initalize_recursive_guard.patch to fix crash with FlexAsio
c3d99a7
to
3989181
Compare
Why adding overlays for pkgconfig and Meson here? |
5afd402
to
9dffdd4
Compare
9dffdd4
to
9f6dd23
Compare
6538fa0
to
07baec2
Compare
07baec2
to
a4da6bf
Compare
It turns out that our vcpkg 2.3 suffers some rotting. Some required downloads are no longer available. The updated packages are not compatible to the old scripts and the new scripts are not working with the other remaining packages. I have tried to make this branch build, but every fix introduces new problems. Updating to upstream main on the other hand, does IMHO not suite to a stable branch. So I have decided to only update PortAudio 19.7.0 + our patches and added the minimum required changes for that. This pulls in a minor Jack update 1.9.21 (from 1.9.14) and a pthreads build scripts update. The pkgconfig and Meson update is required to make the build work that goes not to the result output. Than I have added the new files to the existing mixxx-deps zip archive. |
A Mixxx Windows build for testing can be found here: |
9134276
to
9d78e70
Compare
The linked windows build used still the old Portaudio version. The last commit should fix it. |
Now it is working: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the last Mixxx-Installer from this PR and ASIO is not available in the Sound preferences.
…xxx patches merged
@JoergAtGithub I am glad you found that. There was a merge conflict with changed parameter names and the patches. Luckily all our Mixxx patches are now merged and I have prepared a build from the current upstream HEAD. |
I tested this (the Mixxx provided build https://github.com/daschuer/mixxx/suites/12066844096/artifacts/635057674) on Win7 and Win11. It behaves for me as the old version - note that I'm not affected by these bugs. |
Updating the cache should be Ok for a bugfix release. But it should be noted, that this build.yml no longer generates the complete buildenv from scratch - it all relies on the VCPKG cache. |
Thank you! |
Yes. The issue is that even without this patch the build.yml is not able to generate the complete buildenv. |
Thank you for testing. |
This fixes