Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-mode x64-linux overlay triplet #95

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Nov 9, 2023

Just as a minor convenience for Linux users who want to build with vcpkg instead of the system package manager (yes, I know, not the preferred scenario, but can be convenient for people who want to make statically linked builds).

This adds a copy of the x64-linux triplet with set(VCPKG_BUILD_TYPE release), similar to the existing macOS and Windows triplets. Hopefully vcpkg will at some point get upstream support for this...

Thoughts? Should I target 2.4-rel instead?

@daschuer
Copy link
Member

daschuer commented Nov 9, 2023

We can not longer merge 2.4 to 2.5 like in the mixxx repro. So if you like to have this in 2.4 as well. Just cherry-pick and push directly.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 10c57bf into mixxxdj:2.5-rel Nov 9, 2023
3 checks passed
@fwcd fwcd deleted the x64-linux-overlay branch November 9, 2023 23:18
fwcd added a commit to fwcd/m1xxx that referenced this pull request Nov 9, 2023
This reverts commit 3499ce5.

No longer needed as of mixxxdj/vcpkg#95
fwcd added a commit to fwcd/m1xxx that referenced this pull request Nov 12, 2023
This reverts commit 3499ce5.

No longer needed as of mixxxdj/vcpkg#95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants