Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix after kafka steaming | vcnt | ecnt | #262

Closed
wants to merge 36 commits into from
Closed

fix after kafka steaming | vcnt | ecnt | #262

wants to merge 36 commits into from

Conversation

thamindumk
Copy link
Contributor

No description provided.

thamindumk and others added 30 commits August 16, 2024 23:35
@thamindumk
add feature cypher ast
7707bfb
@thamindumk
add feature cypher ast
71c8349
@thamindumk
add feature cypher ast
6878eb9
@thamindumk
Merge pull request #1 from thamindumk/feature/ast
79ec206 
Feature/ast
@thamindumk
add license and print ast in logger
ab5e605
@thamindumk
Merge pull request #2 from thamindumk/feature/ast
71f3cbe 
add license and print ast in logger
@thamindumk
fix issue on a TODO comment
6a86ee4
@thamindumk
Merge pull request #3 from thamindumk/feature/ast
516cd42 
fix issue on a TODO comment of multipartquery grammar
@thamindumk
add the semantic analyzer
c7670fd
@thamindumk
fixing sonar issues and remove cout and put log instead of cout
922d058
@thamindumk @miyurud
Update src/frontend/JasmineGraphFrontEnd.cpp
6c6ca08 
Co-authored-by: Miyuru Dayarathna <miyurud@yahoo.co.uk>
@thamindumk
fixing standard 17 warnings and errors.
1344c46
@thamindumk
Merge remote-tracking branch 'origin/feature/semantic' into feature/s…
a27b771 
…emantic
@thamindumk
query planner start
d4dab6b
@thamindumk
query planner start
0cc6541
@thamindumk
Merge pull request #4 from miyurud/master
ddbc44b 
update the branch
@thamindumk
const file added
7dbb8de
@thamindumk
set the logger to error message
4da728f
@thamindumk
change more consts
84bdd65
@thamindumk
Merge remote-tracking branch 'origin/feature/queryplaner' into featur…
30f1586 
…e/queryplaner
@thamindumk
Merge remote-tracking branch 'origin/feature/queryplaner' into featur…
710776b 
…e/queryplaner
@thamindumk
using const in queryplanner
a525fe6
@thamindumk
updating const file
d0a5087
@thamindumk
updating query planner with new operators
08ba193
@thamindumk
updating query planner with new operators | UndirectedRelationshipTyp…
b7b5aab 
…eScan
@thamindumk
updating query planner with new operators | filter
397ca53
@thamindumk
updating query planner with new operators | small change in QueryPlan…
c406e52 
…ner.h
@thamindumk
move generated files to prerequisite image
a7c8366
@thamindumk
Merge pull request #5 from miyurud/master
bf32c76 
merge from jasmineGraph master
@thamindumk
Merge pull request #6 from thamindumk/master
f81e74d 
to query planer branch
miyurud
miyurud approved these changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miyurud miyurud mentioned this pull request Dec 7, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 1.44%. Comparing base (bcbae83) to head (77d56b7).

Files with missing lines Patch % Lines
src/partitioner/stream/Partitioner.cpp 0.00% 17 Missing ⚠️
src/util/kafka/StreamHandler.cpp 0.00% 6 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 3 Missing ⚠️
src/partitioner/stream/Partitioner.h 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #262      +/-   ##
=========================================
- Coverage    1.44%   1.44%   -0.01%     
=========================================
  Files          67      67              
  Lines       14288   14310      +22     
  Branches     9055    9068      +13     
=========================================
  Hits          207     207              
- Misses      13877   13899      +22     
  Partials      204     204

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miyurud
miyurud requested changes Dec 8, 2024
View reviewed changes
Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two new comments I have put and reply how you addressed them.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@thamindumk thamindumk closed this Dec 9, 2024
@miyurud miyurud mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miyurud miyurud miyurud requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thamindumk @miyurud