Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --resolve-plugins-relative-to option #279

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

sisisin
Copy link
Contributor

@sisisin sisisin commented Apr 13, 2023

Summary

This Pull Request adds support for the --resolve-plugins-relative-to option in the eslint-interactive

Background

In my monorepo project, I want to use the eslint-interactive tool, but it requires support for the --resolve-plugins-relative-to option which is available in ESLint.

Tests

Although no new tests have been added, I have manually tested this change by building and executing node /path/to/eslint-interactive/bin/eslint-interactive.js --resolve-plugins-relative-to=... command, and confirmed that it works correctly.

@mizdra
Copy link
Owner

mizdra commented Apr 15, 2023

Thank you for contributing!

I have confirmed that --resolve-plugins-relative-to works in my environment. I think I have fixed it without any lack of testing.

@mizdra mizdra added the Type: Feature New Feature label Apr 15, 2023
Copy link
Owner

@mizdra mizdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mizdra mizdra merged commit 1d8c3d2 into mizdra:main Apr 15, 2023
@mizdra mizdra changed the title feat: support --resolve-plugins-relative-to Support --resolve-plugins-relative-to option Apr 15, 2023
@mizdra
Copy link
Owner

mizdra commented Apr 15, 2023

This feature is shipped in v10.7.0.

@sisisin sisisin deleted the feat/support-plugin-option branch June 22, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants