Apply fixes using SourceCodeFixer instead of a plugin
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
added
the
Type: Refactoring
mizdra
force-pushed
the
refactoring-fixer-2
branch
from
8135043
to
e7bea8a
Compare
mizdra
commented
Jan 3, 2024
Comment on lines
-89
to
-94
| // 🤯🤯🤯 THIS IS SUPER HACK!!! 🤯🤯🤯 | ||
| // fix するとコードが変わり、また別の lint エラーが発生する可能性があるため、eslint は `context.report` で | ||
| // 報告されたエラーの fix がすべて終わったら、再び create を呼び出し、また `context.report` で fix 可能なエラーが | ||
| // 報告されないかを確認する仕様になっている (これは `context.report` で fix 可能なものがなくなるまで続く)。 | ||
| // そのため、ここでは2回目以降 create が呼び出された時に、誤って再び fix してしまわないよう、fix 済み | ||
| // であれば early return するようにしている。 |
mizdra
force-pushed
the
refactoring-fixer-2
branch
from
f599e54
to
5763d85
Compare
mizdra
changed the title
SourceCodeFixer instead of a pluginSourceCodeFixer instead of a plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a fifth step towards resolving #283.