Handle calls to failure_slash_error_line[s]. #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failure_slash_error_line is currently not defined in rspec-core (ref https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/formatters/exception_presenter.rb). This change uses it or failure_slash_error_lines if defined. This fix addresses a current breakage, but since the code currently monkeypatches private methods, it may still be brittle.
|
We should still talk with the rspec-core team, I think they're open to expanding their API. I've opened up issue rspec/rspec-core#2169 there. |
|
Hello @mizzy - I opened issue 2169 in rspec-core, and have been asked what you need to ensure you're not monkeypatching private methods and data. That issue has been closed, but if you drop in and add a note then you may be able to get them to make changes to get the data you need in a way that will be supported in the future. Thanks! jz |
|
Thanks @jzohrab. I'll consider it. Anyway, I'll merge your PR. Thanks a lot ! |
mizzy
added a commit
that referenced
this pull request
Feb 9, 2016
Handle calls to failure_slash_error_line[s].
|
Released as v2.29.2. |
|
Not sure why this was merged, this patch doesn't seem correct for any current case. |
oholiab
added a commit
to oholiab/puppet-omnibus
that referenced
this pull request
Jun 30, 2016
This is to get mizzy/serverspec#554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #553
failure_slash_error_line is currently not defined in rspec-core
(ref https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/formatters/exception_presenter.rb).
This change uses it or failure_slash_error_lines if either of those are defined.
Ref this tweet: https://twitter.com/kantrn/status/664913752832126976
I have tried this locally on my cookbook development and the error is resolved. I don't know how to run the rspec tests for serverspec itself, though, so this PR is effectively untested.