Fix be_installed matcher when used with expect #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used like
expect(package('httpd')).to be_installed
it causes an error that subject is not defined
undefined local variable or method `subject' for
#<RSpec::Matchers::DSL::Matcher be_installed> (NameError)
It should be changed to use the passed #match parameter 'name'
instead of 'subject'.
mizzy
requested changes
Nov 7, 2017
| @@ -1,6 +1,6 @@ | |||
| RSpec::Matchers.define :be_installed do | |||
| match do |name| | |||
| if subject.class.name == 'Serverspec::Type::SelinuxModule' | |||
| if name.class.name == 'Serverspec::Type::SelinuxModule' | |||
There was a problem hiding this comment.
Thanks for your PR. Could you change match do |name| to match do |subject| instead of this line , please?
There was a problem hiding this comment.
And please rewrite other name to subject.
There was a problem hiding this comment.
This commit started mixing name and subject:
Before it was called name. So I changed it to 'name'.
Of course we can also rename it to subject. I'll add another commit.
As discussed in mizzy#598 we change the parameter name from match do |name| to match do |subject|
mizzy
approved these changes
Nov 7, 2017
|
Released as v2.41.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used like
expect(package('httpd')).to be_installed
it causes an error that subject is not defined
undefined local variable or method `subject' for
#<RSpec::Matchers::DSL::Matcher be_installed> (NameError)
It should be changed to use the passed #match parameter 'name'
instead of 'subject'.