Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service is_enabled test when using under() #609

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Conversation

adammw
Copy link
Contributor

@adammw adammw commented Aug 16, 2019

Currently running something like:

expect(service('foo')).to be_enabled.under('runit')

throws something like:

NotImplementedError:
    check_is_enabled_runit is not implemented in Specinfra::Command::Ubuntu::V15::Service

This is because the actual method is called check_is_enabled_under_runit.

This PR fixes the method name in a way that previous hacks using expect(service('foo')).to be_enabled.under('under_runit') will still work.

@mizzy
Copy link
Owner

mizzy commented Aug 18, 2019

Good catch. Thanks!

@mizzy mizzy merged commit fd47ef4 into mizzy:master Aug 18, 2019
@mizzy
Copy link
Owner

mizzy commented Aug 18, 2019

Released as v2.41.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants