Remove version constraints in gemspec and some CI workflow fixes #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also mishina2228's comment[1]. [1] mizzy#746 (comment)
See also mishina2228's comment[1]. [1] mizzy#746 (comment) Remove gem version conditionals in gemspec See also mishina2228's comment[1]. [1] mizzy#746 (comment)
Failures:
1) Specinfra::Backend::Exec#build_command with complex command should escape quotes
Failure/Error: if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7')
RuntimeError:
can't modify frozen String
# ./spec/backend/exec/build_command_spec.rb:21:in `new'
# ./spec/backend/exec/build_command_spec.rb:21:in `block (4 levels) in <top (required)>'
Reference: GitHub / ruby / rake / undefined method =~ in Ruby 3.2 mizzy#431 [1] Error output: rake aborted! undefined method `=~' for #<Proc:0x00007f488b282050 /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/rake-10.1.1/lib/rake/application.rb:357 (lambda)> (See full trace by running task with --trace) Error: Process completed with exit code 1. [1] ruby/rake#431
Ruby 2.2.10 cannot be installed on the latest Ubuntu but the Ubuntu 20.04.
Reference: GitHub / ruby / setup-ruby / Bundler install appears broken
on Ruby 2.2 / the summary comment by eregon [1]
Error output:
Installing Bundler
Bundler 2 requires Ruby 2.3+, using Bundler 1 on Ruby <= 2.2
/opt/hostedtoolcache/Ruby/2.2.10/x64/bin/gem install bundler -v ~> 1.0
ERROR: While executing gem ... (RuntimeError)
Marshal.load reentered at marshal_load
Took 0.28 seconds
[1] ruby/setup-ruby#496 (comment)
gemmaro
force-pushed
the
fix/remove-conditionals-in-gemspec
branch
from
cad255f
to
e611262
Compare
gemmaro
force-pushed
the
fix/remove-conditionals-in-gemspec
branch
from
e611262
to
70f5aef
Compare
|
Great work! Thanks a lot! |
|
Released as v2.87.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #746.
The summary of changes are bellow:
Please refer also to the pointers in commit messages.
Best,