Add explicit ranges of dates to the parse_range() method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 19, 2012 11:36
For the rest of the changes coming, we will need to use the ForceDate option of Date::Manip to make sure the date context is setup correctly using the now_callback. Unfortunately, with the functional interface, you can only set ForceDate globally (not per-call). It would be better, therefore, to use the OO interface which allows per-object configuration. However, this is only available in 6.00+, so add a helper method to bridge either interface. When using the older functional interface (either because the developer uses a version of Date::Manip older than 6.00 or because they are using 6.14+ with backend set to "DM5"), we will record the previous ForceDate setting, force the date while we make the call, and then flip it back to the previous setting. If the version of Date::Manip can be tested with DM5 turned one, this adds a test to make sure the ForceDate setting is reverted after each use.
This is implemented in terms of parsing the range recursively, so the performance of this is not as good as it probably could be since we end up constructing additional dates that we throw away. However, it does the job and, unless I'm mistaken, the parsing should proceed in such a way that you will always reach a base case with any input.
|
Thanks, Sterling! This looks awesome at first glance. I'll do some testing tonight and, provided there are no issues, will pull and release to CPAN this evening. |
mjaquilina
added a commit
that referenced
this pull request
Sep 21, 2012
Add explicit ranges of dates to the parse_range() method
afresh1
added a commit
to GrantStreetGroup/Date-RangeParser-EN
that referenced
this pull request
Oct 20, 2023
Merge in GITHUB/date-rangeparser-en from Updates-for-0.9 to master * commit 'fcd105682f57d1cf16f257371bb76676c7f99fd5': (39 commits) Attribute MAq as an author Switch to Dist::Zilla::PluginBundle::Author::GSG Remove .perl-version Tidy up cpanfile Update META yml with version and author Add Verion and Authority to main file Fix business day logic beginning date bugs Change maintained by line Update POD Rearrange elsif portions Condense conditional statements Fix spacing issues Regroup last|past together Improve Dashed Date regex Add todo for all zeros case last and past mintues and hours start and end at BOD, EOD Condense next hours minute seconds logic Make wider use of EOD instead of adding one day and subtracting a second Business day logic autocompletes with incomplete array Condense past hours minutes and seconds to one subroutine ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a number of improvements to Date::RangeParser::EN:
I think that's about it.
I adjusted the TODO section of the POD, which imposes some of my own opinions on the project, but feel free to edit my opinions and strike anything you like from the record.