Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default code text color #132

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix default code text color #132

merged 1 commit into from
Mar 13, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Mar 12, 2024

Fixes #131

VSCode seems to now include a default style for functions and params that was not overridden in the extension and resulted in colors that are hard to read, specifically in light mode.

The problem:

.hljs-subst, .hljs-function, .hljs-title, .hljs-params, .hljs-formula {
    color: rgb(220, 220, 220);
}

This PR updates the function and params colors to use the default fg from the github styles to match closer to how it appears on Github (highlight.js doesn't perfectly match)

I also noticed the .markdown-body .hljs doesn't seem to exist anymore in the MD preview so it wasn't correctly styling the normal text like () and {} so I expanded that selector.

I also updated generate-github-markdown-css because Github made some changes that made it no longer parse correctly. See sindresorhus/generate-github-markdown-css#27 and sindresorhus/generate-github-markdown-css#28

Testing

Add this cpp code block to a test markdown and preview it in all themes and ensure it's readable

#include <cstdin>

int main () {
  int x = 0;
  std::thread t1(inc, std::ref(x), 1);
  std::thread t2(inc, std::ref(x), 2);
  std::thread t3(inc, std::ref(x), 3);
  std::thread t4(inc, std::ref(x), 4);
}

@mjbvz mjbvz merged commit d59f433 into mjbvz:master Mar 13, 2024
@mjbvz
Copy link
Owner

mjbvz commented Mar 13, 2024

Thanks!

@jjspace jjspace deleted the fix-light-syntax branch March 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light theme can't see code body, terrible!
2 participants