Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
VSCode seems to now include a default style for functions and params that was not overridden in the extension and resulted in colors that are hard to read, specifically in light mode.
The problem:
This PR updates the function and params colors to use the default fg from the github styles to match closer to how it appears on Github (highlight.js doesn't perfectly match)
I also noticed the
.markdown-body .hljs
doesn't seem to exist anymore in the MD preview so it wasn't correctly styling the normal text like()
and{}
so I expanded that selector.I also updated
generate-github-markdown-css
because Github made some changes that made it no longer parse correctly. See sindresorhus/generate-github-markdown-css#27 and sindresorhus/generate-github-markdown-css#28Testing
Add this cpp code block to a test markdown and preview it in all themes and ensure it's readable