-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New product ids 0x521C 0x520D 0x5211 0x648C #715
Conversation
* Add support for RM4C mate S (0x5211) * Remove "S" from name
Any predictions for the pull request merge ? |
I would also appreciate a quick fix there as HA is using this repo and after every update of HA we have to manually fix this to get it working again. Is there anything i can do to speed things up? |
Me also voting for enforcing of merge this pull request into next release! =) |
yeah, it's a known issue and known fix, please merge and release, thanks! |
I just bought some of the new RM4C minis and they're not supported. I came to cast my vote to please merge this, thanks! And thank you for all your work as well! |
Can someone help to approve this PR as soon as possible? Thanks in advance! |
@mjg59 Mat, could you merge this PR to next release, please? |
Hi! This branch is internal, it will be merged as soon as I find the time to add some devices that are missing and prepare a new version, thanks! |
Face this lib is very important to keep up to date, because it is used by several other applications and services, the home assistant is one of them, and very used by the people who use it. I only see you currently @felipediel moving this lib forward with the time you have, the other maintainers are not moving this project forward. I understand that after years that this lib was born, it's fucked up to continue without a financial return yet. My advice is to open doors for more people who can maintain this. Upgrading lib versions to add new devices even if it's one, two or three is better than going months without new versions to be added. |
@felipediel Please add the missing devices. |
Context
Proposed change
Add support for the follow new device ids:
Type of change
Additional information
Checklist