Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New product ids 0x521C 0x520D 0x5211 0x648C #715

Closed
wants to merge 4 commits into from

Conversation

titusthefox04
Copy link

Context

Proposed change

Add support for the follow new device ids:

  • 0x521C
  • 0x520D
  • 0x5211
  • 0x648C

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@gtjadsonsantos
Copy link

Any predictions for the pull request merge ?

@unrat
Copy link

unrat commented Sep 22, 2022

Any predictions for the pull request merge ?

I would also appreciate a quick fix there as HA is using this repo and after every update of HA we have to manually fix this to get it working again. Is there anything i can do to speed things up?

@kpblca
Copy link

kpblca commented Sep 29, 2022

Me also voting for enforcing of merge this pull request into next release! =)

@KingOfBaboon
Copy link

yeah, it's a known issue and known fix, please merge and release, thanks!

@mrosun
Copy link

mrosun commented Oct 4, 2022

I just bought some of the new RM4C minis and they're not supported. I came to cast my vote to please merge this, thanks! And thank you for all your work as well!

@jerrychong25
Copy link

Can someone help to approve this PR as soon as possible?

Thanks in advance!

@kpblca
Copy link

kpblca commented Oct 6, 2022

@mjg59 Mat, could you merge this PR to next release, please?
This very useful change is stucked.

@felipediel
Copy link
Collaborator

Hi! This branch is internal, it will be merged as soon as I find the time to add some devices that are missing and prepare a new version, thanks!

@felipediel felipediel closed this Oct 6, 2022
@gtjadsonsantos
Copy link

Face this lib is very important to keep up to date, because it is used by several other applications and services, the home assistant is one of them, and very used by the people who use it.

I only see you currently @felipediel moving this lib forward with the time you have, the other maintainers are not moving this project forward. I understand that after years that this lib was born, it's fucked up to continue without a financial return yet. My advice is to open doors for more people who can maintain this.

Upgrading lib versions to add new devices even if it's one, two or three is better than going months without new versions to be added.

@cfromm1911
Copy link

@felipediel Please add the missing devices.

@guieiras-dev guieiras-dev mentioned this pull request Nov 18, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants