Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert integration tests to use ISLE, not the Playbook #487

Closed
mjordan opened this issue Nov 17, 2022 · 7 comments
Closed

Convert integration tests to use ISLE, not the Playbook #487

mjordan opened this issue Nov 17, 2022 · 7 comments
Assignees
Labels
testing User, unit, and integration testing

Comments

@mjordan
Copy link
Owner

mjordan commented Nov 17, 2022

Since ISLE appears to be the preferred method of running an Islandora instance locally, tests should use it, and not the Playbook, as their target Drupal.

Currently, all integration tests use the following values in their config files:

host: "http://localhost:8000"
username: admin
password: islandora

They should use:

host: https://islandora.traefik.me/
username: admin
password: password

These credentials assume that the ISLE "secrets" are not enabled.

@mjordan mjordan added the testing User, unit, and integration testing label Nov 17, 2022
@mjordan
Copy link
Owner Author

mjordan commented Nov 17, 2022

Running --check errors out with "Error: Field "field_resource_type" required for content type "islandora_object" is not present in the CSV file." Every config file will need to have this added using a field template.

@mjordan mjordan self-assigned this Nov 17, 2022
@mjordan
Copy link
Owner Author

mjordan commented Nov 17, 2022

Turns out that localhost:8000 and password "islandora" work with ISLE.... so no need to change those settings.

@mjordan
Copy link
Owner Author

mjordan commented Aug 4, 2023

Specifically, the ISLE Starter Site, using "password" as the password.

@mjordan
Copy link
Owner Author

mjordan commented Aug 15, 2023

Done so far:

  • TestCreate
  • TestCreateFromFiles
  • TestDelete
  • TestUpdate
  • TestCreateWithNonLatinText
  • TestSecondaryTask
  • TestSecondaryTaskWithGoogleSheets
  • TestSecondaryTaskWithExcel
  • class TestAdditionalFilesCreate(unittest.TestCase):

mjordan added a commit that referenced this issue Aug 15, 2023
mjordan added a commit that referenced this issue Aug 15, 2023
mjordan added a commit that referenced this issue Aug 17, 2023
mjordan added a commit that referenced this issue Aug 17, 2023
mjordan added a commit that referenced this issue Aug 17, 2023
mjordan added a commit that referenced this issue Aug 18, 2023
@mjordan
Copy link
Owner Author

mjordan commented Aug 18, 2023

  • tests/islandora_tests.py
  • tests/islandora_tests_paged_content.py
  • tests/islandora_tests_hooks.py

are complete

mjordan added a commit that referenced this issue Aug 18, 2023
mjordan added a commit that referenced this issue Aug 18, 2023
@ysuarez
Copy link
Contributor

ysuarez commented Aug 19, 2023

@mjordan now that I have been slowly reading and learning the workbench codebase, I may be able to help a bit with this issue. Let me know here or on slack how I can start helping you with this issue.

mjordan added a commit that referenced this issue Aug 22, 2023
@mjordan
Copy link
Owner Author

mjordan commented Aug 22, 2023

Resolved with 47aa7ea.

@mjordan mjordan closed this as completed Aug 22, 2023
mjordan added a commit that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing User, unit, and integration testing
Projects
None yet
Development

No branches or pull requests

2 participants