Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legal_actions をObservationだけから生成する #1076

Merged
merged 69 commits into from
Mar 1, 2022

Conversation

sotetsuk
Copy link
Collaborator

@sotetsuk sotetsuk commented Feb 8, 2022

resolve #1074

API

new_json = mjx.Observation.add_legal_actions(obs_json)
obs = mjx.Observation(new_json)

TODO

  • dummy
  • 自家の番
    • Draw => 九種九牌
    • Draw => ツモ
    • Draw => カン
    • Draw => リーチ
    • Draw => 打牌
    • リーチ => 打牌
    • チー・ポン => 打牌
  • 他家の番
    • 打牌 => ロン・チー・ポン・カン
      • wall_.HasDrawLeft
        • RequireKanDraw
      • CanRon
        • machi
        • discards
        • missed_tiles
        • win_state_info
          • IsFirstTurnWithoutOpen
          • is_ippatsu
          • IsRobbingKan
          • wall_.dora_count
          • wall_.ura_dora_count
        • IsFourKanNoWinner
    • 加カン => ロン
  • game_id 関連

@sotetsuk
Copy link
Collaborator Author

sotetsuk commented Feb 11, 2022

TODO

  • 増やしたいらないstaticを消す
    • RequireKanDraw
    • IsUnderRiichi
  • テストケースを増やす
    • 全ケース
    • 並列化
  • Observation下に移せるか試す
  • シミュレーションでテスト
  • チャンカンを見逃したときのフリテン判定がミスっている

@sotetsuk sotetsuk merged commit 13eb4a6 into master Mar 1, 2022
@sotetsuk sotetsuk deleted the sotetsuk/feat/obs-legal-actions branch March 1, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legal_actions をPython側からObservationに対して生成できるようにする
1 participant