Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow [identifier][], understood as [identifier][identifier] #5

Merged
merged 1 commit into from
Apr 23, 2021
Merged

feat: Allow [identifier][], understood as [identifier][identifier] #5

merged 1 commit into from
Apr 23, 2021

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Apr 21, 2021

No description provided.

oprypin
oprypin commented Apr 21, 2021
View reviewed changes
Copy link
Member Author

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment to clarify this because most tests I'm adding are not for the new behavior

tests/test_references.py Show resolved Hide resolved
tests/test_references.py Show resolved Hide resolved
@oprypin oprypin mentioned this pull request Apr 23, 2021
Closed
@pawamoy
Copy link
Member

pawamoy commented Apr 23, 2021

OK, I feel like it's a nice improvement, and a good base for further improvements. Lets merge.

pawamoy
pawamoy approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawamoy pawamoy merged commit 2d3182d into mkdocstrings:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oprypin @pawamoy