feat: Allow registering absolute URLs for autorefs #8
Conversation
For now this is not used for anything, but the refactor is good for whatever plan we decide to go through regarding inventories.
| if fallback: | ||
| new_identifier = fallback(identifier) | ||
| if new_identifier: | ||
| return self.get_item_url(new_identifier, from_url) |
There was a problem hiding this comment.
Don't we risk infinite recursion here?
There was a problem hiding this comment.
Oh, sorry that there's no explanation for the "cleverness".
The self-call is not exactly the same, fallback is dropped. So, no, there will be only 2 attempts.
I'll add an explicit fallback=None for clarity.
There was a problem hiding this comment.
Ah, my bad for not reading this more thoroughly, I would have seen it 🙂
Thanks for the explanation. The fallback=None is not necessary, but you can add it if you want.
There was a problem hiding this comment.
Ooh let me revert that, there's some failure, and it's a concern for backwards compatibility.
I'll also check in detail why the test failed, I would not have expected that
There was a problem hiding this comment.
This is resolved btw. There wasn't really a problem, just an implicit merge conflict
For now this is not used for anything, but the refactor is good for whatever plan we decide to go through regarding inventories.