refactor: Run static analysis only after the whole package was loaded #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
on_package_loaded
event to statically analyse things only once the whole package was loaded, to avoid the lookup errors described in Could not resolve alias when running griffe + this on Strawberry's codebase #7.@patrick91: I tested on strawberry, and the code duplication workaround isn't needed anymore.
@tiangolo : I checked FastAPI's docs with these changes, all seems good.
Don't hesitate to check for yourselves of course, this would be greatly appreciated 🙂
Unless issues are found, I plan to merge and release this tomorrow.