Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression.full() errors if any Expressions inside it #163

Closed
machow opened this issue May 23, 2023 · 2 comments
Closed

Expression.full() errors if any Expressions inside it #163

machow opened this issue May 23, 2023 · 2 comments

Comments

@machow
Copy link
Contributor

machow commented May 23, 2023

Describe the bug

For griffe v0.28.1, when Expression.full() gets called, if it contains any expressions within it, then it attempts to call .canonical on them, which produces an AttributeError:

AttributeError: 'Expression' object has no attribute 'canonical'

Here's an example that I used to check against:

a: Union[list[str], str]
@pawamoy
Copy link
Member

pawamoy commented May 23, 2023

Damn, how am I not detecting this with the tests suite yet. Thanks for the report, will fix asap

@machow
Copy link
Contributor Author

machow commented May 23, 2023

No worries! I was able to make a quick fix and can submit a PR in a sec! (No worries if you end up fixing another way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants