Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api check: False positive, "object removed" while inherited #203

Closed
pawamoy opened this issue Aug 23, 2023 · 0 comments
Closed

api check: False positive, "object removed" while inherited #203

pawamoy opened this issue Aug 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pawamoy
Copy link
Member

pawamoy commented Aug 23, 2023

I've moved some properties and methods from one class to one of its base class, and Griffe reports that the properties and methods were removed. Since they are inherited, it's an incorrect report. The check command should use all members, not just declared ones, to check if something was removed.
@pawamoy pawamoy added the bug Something isn't working label Aug 23, 2023
pawamoy added a commit that referenced this issue Sep 1, 2023
@pawamoy
fix: Use all members (declared and inherited) when checking for break…
1c4340b 
…ages, avoid false-positives when a member of a class is moved into a parent class

Issue #203: #203
@pawamoy pawamoy closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pawamoy