fix: numpy returns handles more name, type cases #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pawamoy, alright, I think assert_element_equal should be checking all the attributes now. Happy to make any other useful changes |
|
I'm waiting for an answer at numpy/numpydoc#463. Numpydoc maintainers don't particularly like the |
|
Lets wait a few more days, and then proceed to merge. I don't think the discussion on numpydoc will yield immediate results anyway. I'm OK with driving changes rather than waiting for them 🙂 |
pawamoy
approved these changes
Jul 12, 2023
|
Merging, thanks again @machow ! |
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 25, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 26, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 26, 2023
jgarte
added a commit
to jgarte/griffe
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #173 . I'm not particularly good and regexes, so definitely feel free to take this as more of a demonstration of the issue. Happy to make any tweaks / changes :)