-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reporting the attribute who lost their value #225
fix: reporting the attribute who lost their value #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It would be better to pass "unset" to the breakage instance rather than modifying the value in the actual attribute 🙂
Changed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I realise it needs an else
clause, otherwise it would yield both breakages.
Could you also add a test :) ?
ah! yeah sorry for being noob, i assumed it as return keyword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! And thanks for the update 🙂 LGTM now, merging!
This PR Address the #218 issue.
Describe the bug
For example, going from:
to
will report
Attribute value was changed: None -> None
Now modified to
Attribute value was changed: None -> unset