Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better support for dataclasses #240

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Conversation

pawamoy
Copy link
Member

@pawamoy pawamoy commented Feb 29, 2024

Closes #233, #234, #238, #239.

TODO:

  • remove d.py
  • add more tests (coming from mentioned issues)
  • detect when dataclasses extension functionality was used, to issue a deprecation warning? or leave it enabled by default for eternity?

@pawamoy
Copy link
Member Author

pawamoy commented Feb 29, 2024

@has2k1 would you like to review? When squashing I'll add you as co-author since your issues were super helpful and I reused your code for tests 🙂

@has2k1
Copy link
Contributor

has2k1 commented Feb 29, 2024

Nice, looks good so far. I will have time to test it over the weekend.

src/griffe/extensions/base.py Outdated Show resolved Hide resolved
@pawamoy pawamoy force-pushed the better-dataclasses-support branch from f51c37b to b78b2f2 Compare March 5, 2024 14:13
@pawamoy pawamoy merged commit 82a9d57 into main Mar 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: A dataclass field with init=False should not be a parameter
2 participants