-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow named sections after numpy examples #54
Allow named sections after numpy examples #54
Conversation
8674ec9
to
69b6df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Could you simplify the test by reducing the size of the examples section, and by actually testing that first section is examples and second section is parameters? No need to check the examples section contents.
69b6df6
to
c70699c
Compare
Have updated the test 👍 |
3cc9428
to
5ed8db1
Compare
5ed8db1
to
6110596
Compare
Thank you for updating the PR, I had to fix the tests because they were racing 😅 Sorry for the extra work. |
OK, LGTM (failures in CI are irrelevant to this PR). Thanks again! |
Np, just glad i could help 😄 |
This is an attempt at fixing the current behaviour where numpydoc
Examples
sections would erroneously include the content of any following named sections until they reach an unnamed section or the end of the docstring.