Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Rename templates to template.html.jinja #151

Closed
pawamoy opened this issue Apr 21, 2024 · 0 comments · Fixed by #155
Closed

task: Rename templates to template.html.jinja #151

pawamoy opened this issue Apr 21, 2024 · 0 comments · Fixed by #155
Assignees
Labels
templates Jinja templates

Comments

@pawamoy
Copy link
Member

pawamoy commented Apr 21, 2024

Syntax highlighters do not automatically detect that the templates are Jinja templates because they use the .html extension, so they only highlight them as HTML, not Jinja+HTML. I'd like to rename them to use the .html.jinja extension, to enable automatic Jinja+HTML syntax highlighting.

Since templates are overridable, the file names matter, and that's a breaking change. Therefore it needs a deprecation period where we are able to use both the .html and .html.jinja files while emitting warnings when the .html ones are used.

(Also make sure the handler Copier template uses such extensions too)

@pawamoy pawamoy added the templates Jinja templates label Apr 21, 2024
@pawamoy pawamoy self-assigned this Apr 21, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…*.html.jinja` templates, logging a message (info) when `*.html` templates are overridden by users

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
…tml` templates, with an additional `logs` block, and using the updated `get_template` filter

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…a` counterpart, while overriding the `logs` block to issue a logging message (info) stating that extending `*.html` templates is deprecated

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…*.html.jinja` templates, logging a message (info) when `*.html` templates are overridden by users

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
…tml` templates, with an additional `logs` block, and using the updated `get_template` filter

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…a` counterpart, while overriding the `logs` block to issue a logging message (info) stating that extending `*.html` templates is deprecated

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…tml` templates, with an additional `logs` block, and using the updated `get_template` filter

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…a` counterpart, while overriding the `logs` block to issue a logging message (info) stating that extending `*.html` templates is deprecated

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…*.html.jinja` templates, logging a message (info) when `*.html` templates are overridden by users

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
…tml` templates, with an additional `logs` block, and using the updated `get_template` filter

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
…a` counterpart, while overriding the `logs` block to issue a logging message (info) stating that extending `*.html` templates is deprecated

Issue-151: #151
pawamoy added a commit that referenced this issue Apr 28, 2024
pawamoy added a commit that referenced this issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
templates Jinja templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant