-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ed25519 support #75
Conversation
…{c,h}, so it does not work
…ed yet (always fails); signing is not implemented yet (always fatal error)
….c (algorithm not implemented yet, currently Internal error)
To encourage adoption, please consider adding:
after Line 59 in fa116e9
|
This PR ships an own implementation of Curve25519. Meanwhile, libtomcrypt got support for EC25519/Ed25510/X25519. https://github.com/libtom/libtomcrypt/tree/develop/src/pk I guess the way forward is to update the dependency and make use of this implementation. |
The lack of @exploide any thoughts on starting a new pull request for updating |
@jakimfett I have no dev experience with dropbear and libtomcrypt. I guess @mkj and @sjaeckel know better what is needed to bring Curve25519 support to dropbear. |
@exploide @jakimfett The Ed25519 was introduced on OpenSSH version 6.5. It’s the EdDSA implementation using the Twisted Edwards curve. It’s using elliptic curve cryptography that offers a better security with faster performance compared to DSA or ECDSA. |
@jakimfett well, libtomcrypt with curve25519/ed25519 is not out yet. in my implementation (see #91), same curve25519 library is used as in libtomcrypt but use is more optimal regarding both size and memory consumtion. probably external upcoming (oneday) libtomcrypt with shared ed25519 is the only case when builtin lib can be disabled to have any gain. |
I've now merged #91 |
I've rebased @pts's ed25519 support onto master, and added a small fix to make dbclient work with ed25519 too. It seems to work, and be compatible with openssh, but I can't personally vouch for its correctness.
The whole pts tree is rebased onto the official tree here if anyone wants to cherry pick some of the other changes.