Don't use py3.10 TypeAlias in pyodbc.pyi #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnelson-nist
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
I've tested this, and confirm this addresses the issues I raised in #1186. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #1186 , the typing construct
TypeAliaswas introduced in Python 3.10. This is causing mypy issues with people who are using older versions of Python. Hence, drop theTypeAliasreferences inpyodbc.pyiand just use the raw typing definition for cursor descriptions. This appears to solve the mypy issue:Note, the
Finaltyping references are being kept, despite them being introduced only in Python 3.8.