Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MatrixArgs.element and Update cmr #29

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Fix MatrixArgs.element and Update cmr #29

merged 4 commits into from
Mar 4, 2024

Conversation

xuluze
Copy link

@xuluze xuluze commented Mar 4, 2024

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@xuluze
Copy link
Author

xuluze commented Mar 4, 2024

The order of bint immutable=False, bint convert=True is swapped because MatrixArgs.element(immutable=immutable) cause missing convert

@mkoeppe mkoeppe merged commit 14dedff into mkoeppe:cmr Mar 4, 2024
6 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuluze @mkoeppe