t/31312/interactive simplex method improve support for base fields other than qq #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
merged commit 775dd97
into
mkoeppe:t/31312/interactive_simplex_method__improve_support_for_base_fields_other_than_qq__rdf
1 check passed
mkoeppe
pushed a commit
that referenced
this pull request
May 12, 2024
Bumps [easimon/maximize-build- space](https://github.com/easimon/maximize-build-space) from 8 to 10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/easimon/maximize-build- space/releases">easimon/maximize-build-space's releases</a>.</em></p> <blockquote> <h2>Fix: Build Mount folder Ownership</h2> <h2>What's Changed</h2> <ul> <li>fix: if the build mount "deleted" / shadowed the GITHUB_WORKSPACE, do not only recreate it, but also ensure it belongs to the correct owner (<code>runner</code>) again</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/easimon/maximize-build- space/compare/v9...v10">https://github.com/easimon/maximize-build- space/compare/v9...v10</a></p> <h2>Allow build mount path to be a parent of $GITHUB_WORKSPACE</h2> <p>This release adds support for mounting the build volume over a <em>parent</em> folder of <code>$GITHUB_WORKSPACE</code>.</p> <p>Previously, doing so would remove/shadow the current working directory, and make any later actions/steps fail.</p> <p>New features:</p> <ul> <li>Warn about $BUILD_MOUNT_PATH not being empty and list contents in that case</li> <li>Recreate <code>$GITHUB_WORKSPACE</code> afterwards if missing, so following actions have a working directory to start from.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/easimon/maximize-build- space/blob/master/CHANGELOG.md">easimon/maximize-build-space's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>[v4] - 2021-03-25: Do not overprovision space by default</h2> <h3>Added</h3> <ul> <li>Configuration option of overprovisioning the build volume (<code>overprovision-lvm</code>), defaulting to <code>'false'</code>.</li> <li>Configurable temp volume reserve (<code>temp-reserve-mb</code>), defaulting to <code>'100'</code>.</li> </ul> <h3>Changed</h3> <ul> <li>(potentially breaking) The LVM image files are not created sparsely anymore. Previously, free disk space <em>appeared</em> free on <strong>both</strong> the build volume and the hosting volume, until actually allocated by writing to the build volume. Now, the space is actually consumed on volume creation -- meaning, that after creating the build volume, the root and temp volume do not have or show more space available than configured in <code>root-reserve-mb</code> and <code>temp-reserve-mb</code>. This can be reverted by setting <code>overprovision-lvm</code> to <code>'true'</code>, but surprising out-of-disk space situations might be the result.</li> <li>Temp volume reserve was fixed to 1024 KB, this defaults to a more cautious 100 MB now, and is configurable.</li> </ul> <h2>[v3] - 2021-02-15: Fix running on Ubuntu 20.04</h2> <h3>Changed</h3> <ul> <li>Includes a workaround for the temp disk being locked on Ubuntu 20.04. Instead of formatting the temp disk, the LVM volume is now created ontop of loop-mounted files on both / and /mnt, leaving the original file systems intact.</li> </ul> <h2>[v2] - 2021-01-05: Fix file system permissions on logical volume</h2> <h3>Changed</h3> <ul> <li>Change the owner of the logical volume to the runner user recursively, fixing permission issues when e.g. checking out code to the root of the logical volume. (Actually, the problem is the lost+found folder in the ext4 root, and chowning it breaks its purpose. But since the volume is temporary anyway, lost+found functionality is not really needed).</li> </ul> <h2>[v1] - 2020-08-20: Initial release</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="easimon/maximize-build-space@fc88 1a613ad2a34aca9c9624518214ebc21dfc0c"><code>fc881a6</code></a> Merge pull request <a href="https://redirect.github.com/easimon/maximize- build-space/issues/36">#36</a> from easimon/fix/ownership-of-github- workspace</li> <li><a href="easimon/maximize-build-space@fadc 013e293a3453768b4ddb9db8c85104752807"><code>fadc013</code></a> fix: recreate GITHUB_WORKSPACE with correct owner when deleted</li> <li><a href="easimon/maximize-build-space@cd65 2e0aff3ca18221e78cfc9b00daca32624434"><code>cd652e0</code></a> fix: test build mount set to parent of current workspace</li> <li><a href="easimon/maximize-build-space@bb67 daa4a202a2ea017b6410ea1f07da0c9a0251"><code>bb67daa</code></a> Merge pull request <a href="https://redirect.github.com/easimon/maximize- build-space/issues/35">#35</a> from easimon/fix/find-with-sudo</li> <li><a href="easimon/maximize-build-space@fe04 31d2ea5d3f901672ecc5e5d3321a5aab0d4b"><code>fe0431d</code></a> fix: run free space reports with sudo as well</li> <li><a href="easimon/maximize-build-space@557c b009e7800b893a76650025e3fb5e9703cd1e"><code>557cb00</code></a> test: add test for root-owned build path</li> <li><a href="easimon/maximize-build-space@aed4 1c1277827a01ad47f165f7ef86d7e93bcb68"><code>aed41c1</code></a> fix: run find with root permissions</li> <li><a href="easimon/maximize-build-space@89c6 c4b591707546240d146f5401decdc9c2e703"><code>89c6c4b</code></a> fix: remove duplicate mkdir</li> <li><a href="easimon/maximize-build-space@69e8 e4594e28d84544836af5c7d0fb59e15da8d1"><code>69e8e45</code></a> Merge pull request <a href="https://redirect.github.com/easimon/maximize- build-space/issues/33">#33</a> from easimon/fix/allow-removal-of- workspace-directory</li> <li><a href="easimon/maximize-build-space@62d3 79bbe31e834154be288e762650b7fa7619a4"><code>62d379b</code></a> feat: show directory contents of build mount path if not empty</li> <li>Additional commits viewable in <a href="https://github.com/easimon/maximize-build- space/compare/v8...v10">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security- vulnerabilities/about-dependabot-security-updates#about-compatibility- scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> URL: sagemath#37944 Reported by: dependabot[bot] Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sagemath issue #31312
I've added a backend option, RDF tests, and fixed doc tests according to comments left on the issue.
📝 Checklist
⌛ Dependencies