Skip to content

Commit

Permalink
Add Ledger support for Musicoin
Browse files Browse the repository at this point in the history
EIP-155 is now properly working with Musicoin!! Tested personally on the Ledger Nano S

    homepage           : https://musicoin.org
    block explorer     : https://explorer.musicoin.org
    slip0044 index     : 184
    chainId            : 7762959

Musicoin has been unable to work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c

The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February:
Musicoin/go-musicoin#62

Musicoin is on LedgerHQ official roadmap:
https://trello.com/c/a3YFOxx1/114-musicoin-support

LedgerHQ official Musicoin app support: (merged)
LedgerHQ/app-ethereum#20
  • Loading branch information
mkrufky committed Aug 30, 2018
1 parent 14c41bc commit 1de8d83
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions app/scripts/controllers/decryptWalletCtrl.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ var decryptWalletCtrl = function($scope, $sce, walletService) {
case nodes.nodeTypes.EGEM:
$scope.HDWallet.dPath = $scope.HDWallet.hwEtherGemPath;
break;
case nodes.nodeTypes.MUSIC:
$scope.HDWallet.dPath = $scope.HDWallet.hwMusicoinPath;
break;
default:
$scope.HDWallet.dPath = $scope.HDWallet.ledgerPath;
}
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/directives/walletDecryptDrtv.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h4 translate="decrypt_Access">
<!-- Ledger -->
<label aria-flowto="aria3"
class="radio"
ng-show="ajaxReq.type=='ETH'||ajaxReq.type=='ETC'||ajaxReq.type=='ROPSTEN ETH'||ajaxReq.type=='RINKEBY ETH'||ajaxReq.type=='KOVAN ETH'||ajaxReq.type=='EXP'||ajaxReq.type=='UBQ'||ajaxReq.type=='POA'||ajaxReq.type=='TOMO'||ajaxReq.type=='ESN'||ajaxReq.type=='AKROMA'||ajaxReq.type=='PIRL'||ajaxReq.type=='ETHO'||ajaxReq.type=='EGEM'||ajaxReq.type=='CLO'||ajaxReq.type=='ATH'">
ng-show="ajaxReq.type=='ETH'||ajaxReq.type=='ETC'||ajaxReq.type=='ROPSTEN ETH'||ajaxReq.type=='RINKEBY ETH'||ajaxReq.type=='KOVAN ETH'||ajaxReq.type=='EXP'||ajaxReq.type=='UBQ'||ajaxReq.type=='POA'||ajaxReq.type=='TOMO'||ajaxReq.type=='ESN'||ajaxReq.type=='AKROMA'||ajaxReq.type=='PIRL'||ajaxReq.type=='ETHO'||ajaxReq.type=='EGEM'||ajaxReq.type=='CLO'||ajaxReq.type=='ATH'||ajaxReq.type=='MUSIC'">
<input aria-flowto="aria3"
type="radio"
aria-label="Ledger Hardware Wallet"
Expand Down

0 comments on commit 1de8d83

Please sign in to comment.