Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disabled exposing the Dask diagnostic dashboard #872

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Temporarily disabled exposing the Dask diagnostic dashboard #872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2c61e8
Temporarily disabled exposing the Dask diagnostic dashboard port to t…
mrchtr Feb 22, 2024
77a5b2d
Addressing comments
mrchtr Feb 26, 2024
15569bd
Make dask diagnostics port configurable
RobbeSneyders Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/fondant/pipeline/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@

logger = logging.getLogger(__name__)

DASK_DIAGNOSTIC_DASHBOARD_PORT = 8787
# export DASK_DIAGNOSTICS_PORT="" to get a dynamic port assigned
DASK_DIAGNOSTICS_PORT = os.environ.get("DASK_DIAGNOSTICS_PORT", ":8787")

KubeflowCommandArguments = t.List[t.Union[str, t.Dict[str, str]]]


Expand Down Expand Up @@ -258,10 +260,7 @@ def _generate_spec(
if extra_volumes:
volumes.extend(extra_volumes)

ports: t.List[t.Union[str, dict]] = []
ports.append(
f"{DASK_DIAGNOSTIC_DASHBOARD_PORT}:{DASK_DIAGNOSTIC_DASHBOARD_PORT}",
)
ports = [f"8787{DASK_DIAGNOSTICS_PORT}"]

services[component_id] = {
"entrypoint": entrypoint,
Expand Down
Loading