Using a variables view dispatch and toolbars #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes two variables
calfw-blocks-toolbar-viewsandcalfw-blocks-view-dipatch-funcsfor better code factoring and an easier way to add views. These should really be part of emacs-calfw, but that package seems not to be maintained anymore. So I propose either including these variables in calfw-blocks or forking emacs-calfw and basing calfw-block on an enhanced fork.Context
Over in my fork, I made several changes that I think improve the overall view and quality of the calfw and calfw-blocks. One of the main changes is that I split the code for transposed views into its own file since I don't use them. Adding these two variables make it easy to include or exclude these views without re-advising the view dispatch and toolbar rendering functions.
I have used my fork for a while now and I am happy to create pull requests for some or all of these features if there's interest (you can check the readme on my fork for a list of changes).