[WIP] UI improvements for structural editor #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those all sound like great ideas. I suspect switching to crossterm will make a lot of them easier, so I'll go ahead and look into that and maybe go ahead and commit to |
ThePuzzlemaker
force-pushed
the
ui-improvements
branch
2 times, most recently
from
2a8edbd to
08c3aba
Compare
brightly-salty
added a commit
that referenced
this pull request
Oct 5, 2021
* AST/parser changes, remove anyhow Patched out editor for now just because it'd be too borked Co-authored-by: Caden Haustein <code@brightlysalty.33mail.com> * Use unic-ucd-category intead of unic-ucd Co-authored-by: Caden Haustein <code@brightlysalty.33mail.com>
ThePuzzlemaker
force-pushed
the
ui-improvements
branch
from
08c3aba to
19d948a
Compare
This makes everything cleaner! With some algebra and code™, it's possible to use `format!` for centering text. This commit also adds labels to the pattern and replacement half, just being centered boxes `| Pattern |` and `| Replacement |` in the usually bland `--------`(...) line after the status.
Squash of: - Switch from termion to crossterm (@brightly-salty) - Abstract away a view for easier layouting (@brightly-salty) - Add lockfile (@ThePuzzlemaker) - Undo some AST/parser changes (@ThePuzzlemaker) Co-authored-by: ThePuzzlemaker <tpzker@thepuzzlemaker.info>
ThePuzzlemaker
force-pushed
the
ui-improvements
branch
from
19d948a to
396ea29
Compare
ThePuzzlemaker
commented
Oct 5, 2021
brightly-salty
added a commit
that referenced
this pull request
Oct 7, 2021
* Initial Rust work * Fix clippy hints, better error handling * Build time + runtime improvements * Add structured editor * Fix prelude and allow newlines/CR (#31) * AST/Parser changes (From #34 , separated into this PR) (#36) * AST/parser changes, remove anyhow Patched out editor for now just because it'd be too borked Co-authored-by: Caden Haustein <code@brightlysalty.33mail.com> * Use unic-ucd-category intead of unic-ucd Co-authored-by: Caden Haustein <code@brightlysalty.33mail.com> * [WIP] Improved codegen (#34) * UI improvements for structural editor (#32) * Use std::fmt for centering, add labels for halves This makes everything cleaner! With some algebra and code™, it's possible to use `format!` for centering text. This commit also adds labels to the pattern and replacement half, just being centered boxes `| Pattern |` and `| Replacement |` in the usually bland `--------`(...) line after the status. * Fix rule index (off-by-one errors go brrr) * Switch from termion to crossterm Squash of: - Switch from termion to crossterm (@brightly-salty) - Abstract away a view for easier layouting (@brightly-salty) - Add lockfile (@ThePuzzlemaker) - Undo some AST/parser changes (@ThePuzzlemaker) Co-authored-by: ThePuzzlemaker <tpzker@thepuzzlemaker.info> * Fix code for new AST, make pretty_rule use &[Term] instead of Vec<Term> * Rebase and fix * Add failing interactive mode * Improve interactive rewriter * Fix prelude + mlatu.pl * Add CLI + standardize keybindings Co-authored-by: Caden Haustein <code@brightlysalty.33mail.com> * Update documentation Co-authored-by: James [Undefined] <tpzker@thepuzzlemaker.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like making CLI apps :)
What's here so far
What's to come... maybe
Notes
This technically depends on #31 because git is hard. If you don't want to merge that for whatever reason (or need me to change it), let me know and I'll rebase as needed :)
This is not fully tested, but neither is the original as far as I know, so uh... here be dragons :P
Let me know if there's anything I should add here! I'd probably be willing to work on it :)