[Feature] Replace BroadcastChannel API with Client API in Service Worker #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neet-Nestor
changed the title
CharlieFRuan
added a commit
that referenced
this pull request
May 21, 2024
### Changes Main changes include: - New model `Hermes-2-Pro-Mistral-7B` in `prebuiltAppConfig` via: - #390 - Various `index.js` and `index.js.map` post-processings to resolve frontend compatibility issues with `require()` and `perf_hoooks` - #397 - #406 - Catch WebGPU OOM error upon `reload()` and `CreateEngine()`: - #402 - Service Worker support (in addition to Extension Service Worker): - #395 - #400 - #401 ### WASM Version v0_2_34 as no change is required. ### TVMjs TVMjs compiled at apache/tvm@a5862a5, with only one change in `tvm/web`: apache/tvm#17005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There are many different APIs available for the two-way communication between service worker and web pages. According to the suggestion of web.dev, previously we used the simple BroadcastChannel API.
https://web.dev/articles/two-way-communication-guide
However, if the service worker has been killed by the browser, messages sent via the BroadcastChannel API cannot revive it. This causes unstable service worker life while users are using the webapp.
This PR replaces BroadcastChannel API with the more primitive Client API as we found that messages sent via Client API will revive a stopped service worker. This ensures the normal functioning of our keep-alive mechanism.
Primary Change
BroadcastChannelwith Client API (navigator.serviceWorker.controller.postMessage()andclient.postMessage())clientRegistryto remember mapping between incoming messages and client idsweb_service_worker.ts->service_worker.tsservice_worker.ts->extension_service_worker.tsTesting
examples/service-workerThe chat webapp is able to correctly keeping service worker alive after this change.