Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules calling simplified #33

Conversation

AlexandruAntonescuKeysight
Copy link
Contributor

Summary

This PR is intended to simplify the modules calling. It has the following additions:

  • updates the github checkout action to the last version
  • offers a solution to that redundancy problem when calling modules. For this, the pyproject.toml file was enhanced and the structure of the project was not modified.
  • now the user can call a module like this:

chakra_generator --num_npus 1

instead of

python3 -m chakra.et_generator.et_generator --num_npus 1

  • also, the old syntax is still available
  • updates the main.yml workflow example to match the new syntax

Test Plan

Tested locally after installing the package.
Tested to see if it behaves the same as the previous approach of calling modules.

@AlexandruAntonescuKeysight AlexandruAntonescuKeysight requested a review from a team as a code owner April 3, 2024 15:42
Copy link

github-actions bot commented Apr 3, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@srinivas212 srinivas212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contributions.

@srinivas212 srinivas212 merged commit 07c94f0 into mlcommons:main Apr 5, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants