Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding trace link files from Params repo to here #41

Merged
merged 1 commit into from
May 8, 2024

Conversation

sanrise
Copy link

@sanrise sanrise commented Apr 19, 2024

As per the Chakra forum's consensus, let's move the trace link from param repo to here.
This commit simply moves these files, we will need to follow up with a diff to integrate them.

@sanrise sanrise requested a review from a team as a code owner April 19, 2024 19:15
Copy link

github-actions bot commented Apr 19, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wkaisertexas
Copy link

Can someone merge this?

@JoongunPark
Copy link
Contributor

This looks good to me!

@sanrise
Copy link
Author

sanrise commented May 6, 2024

recheck

@TaekyungHeo
Copy link
Contributor

Is there any update on CLA, @sanrise ?

@sanrise
Copy link
Author

sanrise commented May 6, 2024

recheck

@sanrise
Copy link
Author

sanrise commented May 6, 2024

Is there any update on CLA, @sanrise ?

something is not right, the github-actions bot says the CLA is fine (since it's Meta, I shouldn't be having to sign anything myself) but the merge checks are failing for cla-check

@TaekyungHeo
Copy link
Contributor

Maybe Meta has to sign CLA on behalf of you. Do you have any idea, @srinivas212?

@sanrise
Copy link
Author

sanrise commented May 6, 2024

Maybe Meta has to sign CLA on behalf of you. Do you have any idea, @srinivas212?

image I also think a member of the wg-chakra group needs to approve this PR. it's not approved yet (check attached image).

Copy link
Contributor

@srinivas212 srinivas212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathanw-mlc
Copy link
Member

The recheck command is currently broken, so you have to manually re-run the check. You should be good to go now.

@srinivas212
Copy link
Contributor

srinivas212 commented May 8, 2024

Note for future reference: the PR will break linter and other formatters. @TaekyungHeo is already working on fixing these issues. This PR is mainly to contribute the code from Meta to MLC repo by Meta employee.

@srinivas212 srinivas212 merged commit 3964d73 into mlcommons:main May 8, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants