-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding trace link files from Params repo to here #41
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Can someone merge this? |
This looks good to me! |
recheck |
Is there any update on CLA, @sanrise ? |
recheck |
something is not right, the github-actions bot says the CLA is fine (since it's Meta, I shouldn't be having to sign anything myself) but the merge checks are failing for cla-check |
Maybe Meta has to sign CLA on behalf of you. Do you have any idea, @srinivas212? |
I also think a member of the wg-chakra group needs to approve this PR. it's not approved yet (check attached image). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The recheck command is currently broken, so you have to manually re-run the check. You should be good to go now. |
Note for future reference: the PR will break linter and other formatters. @TaekyungHeo is already working on fixing these issues. This PR is mainly to contribute the code from Meta to MLC repo by Meta employee. |
As per the Chakra forum's consensus, let's move the trace link from param repo to here.
This commit simply moves these files, we will need to follow up with a diff to integrate them.